Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade cli-style #614

Merged
merged 7 commits into from
May 28, 2024
Merged

chore: upgrade cli-style #614

merged 7 commits into from
May 28, 2024

Conversation

ismay
Copy link
Contributor

@ismay ismay commented May 23, 2024

https://dhis2.atlassian.net/browse/DHIS2-16776

  • disabled import/no-unused-modules for stylelint config (the module isn't used in the app, but by the d2-style lib, that's not detected by the eslint rule)
  • deduplicated postcss to ensure single version, with npx yarn-deduplicate, fixes: [v8.4.19] Cannot read properties of undefined (reading 'stringify') postcss/postcss#1791
  • removed d2-style.config.js so that it falls back to the default, should suffice
  • ran yarn add --dev @dhis2/cli-style@latest && yarn exec d2-style add stylelint
  • used yarn exec d2-style apply css to autofix all the css

@dhis2-bot
Copy link
Contributor

dhis2-bot commented May 23, 2024

🚀 Deployed on https://pr-614--dhis2-scheduler.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify May 23, 2024 11:40 Inactive
@ismay ismay force-pushed the upgrade-cli-style branch from ccf0573 to bb5e4cb Compare May 27, 2024 08:16
@dhis2-bot dhis2-bot temporarily deployed to netlify May 27, 2024 08:21 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 27, 2024 08:36 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 27, 2024 08:43 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 27, 2024 08:49 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 27, 2024 14:28 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify May 27, 2024 14:38 Inactive
@ismay ismay marked this pull request as ready for review May 27, 2024 14:41
@ismay ismay requested review from a team as code owners May 27, 2024 14:41
@ismay ismay merged commit 365263f into master May 28, 2024
13 checks passed
@ismay ismay deleted the upgrade-cli-style branch May 28, 2024 07:49
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.6.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v8.4.19] Cannot read properties of undefined (reading 'stringify')
3 participants